Re: [JUST RFC] ARM: DIGIC: add csrc-dummy

[Alexander Shiyan]

> On Sun, 15 Dec 2013 22:08:00 +0400
> Alexander Shiyan <shc_work at mail.ru> wrote:
> 
> > > The clocksource csrc-timer driver that uses DIGIC
> > > hardware TIMER2 perfectrly works on Canon A1100,
> > > but does not works on Canon EOS 600D.
> > > IMHO we need additional timer initialisation.
> > > 
> > > This patch introduces a quick-and-dirty termporary
> > > solution for this situation: a clocksource driver that
> > > does not use any hardware at all.
> > > 
> > > Also this driver is very handy for running barebox
> > > on Magic Lantern EOS qemu-based emulator as
> > > the emulator does not realize timer counter register at all!
> > > 
> > > Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> > ...
> > > +	printf("clocksource_init: mult=%08x, shift=%08x\n",
> > > +			dummy_cs.mult, dummy_cs.shift);
> > 
> > No reason to spam into console. Put this into pr_debug.
> > 
> 
> Of cause there is no reason to spam into console!
> 
> This patch is mailed only for illustration of the concept,
> it even can't be applyed.
> 
> Have you any comments on the concept itself?

I am not a guru, sorry :)

---