[PATCH] serial: add missing depends on ARCH_ZYNQ
Alexander Aring
alex.aring at gmail.com
Fri Dec 6 06:59:56 EST 2013
Hi Steffen,
On Fri, Dec 06, 2013 at 10:07:32AM +0100, Steffen Trumtrar wrote:
> Hi!
>
> On Thu, Dec 05, 2013 at 12:28:11AM +0100, Alexander Aring wrote:
> > The cadence serial driver is some ARCH_ZYNQ specific driver.
> > Add a depends on ARCH_ZYNQ for this driver.
> >
> > Signed-off-by: Alexander Aring <alex.aring at gmail.com>
> > ---
> > drivers/serial/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/serial/Kconfig b/drivers/serial/Kconfig
> > index 11fc155..d520dda 100644
> > --- a/drivers/serial/Kconfig
> > +++ b/drivers/serial/Kconfig
> > @@ -119,6 +119,7 @@ config DRIVER_SERIAL_OMAP4_USBBOOT
> >
> > config DRIVER_SERIAL_CADENCE
> > bool "Cadence UART driver"
> > + depends on ARCH_ZYNQ
> > help
> > Say Y here if you have a Cadence serial IP core.
> >
> > --
> > 1.8.4.2
> >
> >
> > _______________________________________________
> > barebox mailing list
> > barebox at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/barebox
> >
>
> Does is not compile with other archs?
> This is intended to be a generic driver; Zynq just happens to be the only user.
> -> It should not depend on ARCH_ZYNQ.
oh, I first figure out a depends on COMMON_CLK was missing and though
that this driver is a platform specific driver.
When it's a generic driver we should add a "depends on COMMON_CLK"
because there are some generic clock api calls.
- Alex
More information about the barebox
mailing list