[PATCH] Added sd driver for bcm2835 (Raspberry PI)

[Sascha Hauer]

On Tue, Apr 23, 2013 at 03:41:45PM +0200, wilhelm wrote:
> ---
>  arch/arm/mach-bcm2835/core.c |   1 +
>  drivers/mci/Kconfig          |   5 +
>  drivers/mci/Makefile         |   1 +
>  drivers/mci/mci-bcm2835.c    | 551 +++++++++++++++++++++++++++++++++++++++++++
>  drivers/mci/mci-bcm2835.h    | 126 ++++++++++
>  5 files changed, 684 insertions(+)
>  create mode 100644 drivers/mci/mci-bcm2835.c
>  create mode 100644 drivers/mci/mci-bcm2835.h
> 
> diff --git a/drivers/mci/mci-bcm2835.c b/drivers/mci/mci-bcm2835.c
> new file mode 100644
> index 0000000..29afe0c
> --- /dev/null
> +++ b/drivers/mci/mci-bcm2835.c
> @@ -0,0 +1,551 @@
> +/*
> + * Raspberry PI MCI driver
> + *
> + * Portions (e.g. read/write macros, concepts for back-to-back register write
> + * timing workarounds) obviously extracted from the Linux kernel at:
> + * https://github.com/raspberrypi/linux.git rpi-3.6.y
> + *
> + * The Linux kernel code has the following (c) and license, which is hence
> + * propagated to here:
> + *
> + * Support for SDHCI device on 2835
> + * Based on sdhci-bcm2708.c (c) 2010 Broadcom
> + * Inspired by bcm2835_sdhci.c from git://github.com/gonzoua/u-boot-pi.git

Although it's hard to see this is a SDHCI driver. The same hardware is
used on i.MX and I think also on Zynq.

>From the i.MX SDHCI controller I know that it needs several quirks which
will make it hard writing a common driver. At least the kernel (i.MX-)
SDHCI driver looks nasty.

So writing a common driver may not be worth it, but I think we should
aim for a common set of register defines. This would make it a lot
easier to share code and to at least compare the drivers. I just sent
out an initial series for this, maybe you could switch your driver
to use the same defines. Later we could then search for common code.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |