[PATCH 1/5] phylib: bus reset function

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Thu Sep 20 14:23:32 EDT 2012


On 17:31 Thu 20 Sep     , Renaud Barbier wrote:
> Added an entry point for a bus reset function.
> 
> Signed-off-by: Renaud Barbier <renaud.barbier at ge.com>
> ---
>  drivers/net/phy/phy.c |    3 +++
>  include/miidev.h      |    1 +
>  2 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 5406ea3..d9f5409 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -129,6 +129,9 @@ int phy_device_connect(struct eth_device *edev, struct mii_device *bus, int addr
>  	unsigned int i;
>  	int ret = -EINVAL;
>  
> +	if (bus->reset)
> +		bus->reset(bus);
> +
I do not like this we should not touch the bus at phy connect

Best Regards,
J.



More information about the barebox mailing list