[PATCH 02/11] bmp: split bmp rending in lib/bmp.c

[Sascha Hauer]

In Subject: s/rending/rendering/

Or better: Move bmp rendering to lib/bmp.c

On Sat, Sep 08, 2012 at 08:05:33PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> @@ -34,3 +34,4 @@ obj-$(CONFIG_UNCOMPRESS)	+= uncompress.o
>  obj-$(CONFIG_BCH)	+= bch.o
>  obj-$(CONFIG_BITREV)	+= bitrev.o
>  obj-$(CONFIG_QSORT)	+= qsort.o
> +obj-$(CONFIG_BMP)	+= bmp.o
> diff --git a/lib/bmp.c b/lib/bmp.c
> new file mode 100644
> index 0000000..776d3b3
> --- /dev/null
> +++ b/lib/bmp.c
> @@ -0,0 +1,132 @@
> +#include <common.h>
> +#include <fs.h>
> +#include <errno.h>
> +#include <malloc.h>
> +#include <fb.h>
> +#include <bmp_layout.h>
> +#include <asm/byteorder.h>
> +
> +static inline void set_pixel(struct fb_info *info, void *adr, int r, int g, int b)

This function is first moved from commands/bmp.c to lib/bmp.c, then
added as a static inline to include/image_renderer.h, then removed again
from lib/bmp.c, then removed from include/image_renderer.h, then
reintroduced as a different function in include/graphic_utils.h.

Can you please reorder your patch series to make it readable so that we
can see what actually happens?

Thanks
 Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |