[PATCH 09/11] defaultenv-2: boot/net add bootp support

[Sascha Hauer]

On Sat, Sep 08, 2012 at 07:12:29PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Look, there are so many possible setups.
> > 
> > - kernel on tftp, disk, nand
> > - oftree on tftp, disk, nand, none at all
> > - root on nfs, disk, nand
> > 
> > Even the above makes for 36 combinations, different names/partitions not
> > counted. The setups are board specific, company specific, project
> > specific or person specific. There is no way of making all happy with a
> > single script. Instead the bootscripts are meant as an *example* to get
> > started, they are *not* meant to fit all your and everyone elses needs.
> > 
> > You want to get your oftree path from a dhcp request? Then fine, change
> > global.bootm.oftree to "${path}/${global.dhcp.oftree_file}". You want
> > to use the one from /env/oftree? Then change global.bootm.oftree
> > accordingly. You want to use one as a fallback from another one? Also
> > fine, do some if/else.
> > 
> > But please don't try to force your specific setup to other people.
> I force nothing I just add the generic bootp support

Sure you do. For example you leave no option to not use
$global.dhcp.rootpath even if set. There is no option to not use
$global.dhcp.bootfile even if set. Yes, you could add an option
somewhere, but that would make the boot scripts even more complicated.

The boot scripts are not the place to add code. You can add a
helper script to do whatever magic you need; and if it's sufficiently
useful we can add it to the tree.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |