[PATCH 6/8] drivers/net: add driver for the EMAC device found in some TI SoCs

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:20 Thu 06 Sep     , Sascha Hauer wrote:
> On Wed, Sep 05, 2012 at 08:03:20PM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 17:52 Wed 05 Sep     , Jan Luebbe wrote:
> > > Signed-off-by: Jan Luebbe <jlu at pengutronix.de>
> > Again NACK
> > 
> > drop the struct XXXX on hte reg
> 
> I also don't like it, but let's not be religious about it.
> Wolfgang currently forces all people to use structs for registers.
> Forcing exactly the opposite is counterproductive I think. The original
> drivers uses the structs and at some point it can be useful to compare
> to this driver.
this is really a shit to read the code is horible

So at the point we need to sync with the kernel

I'm working on the amba pl180 driver currently if I use the u-boot one my
board boot in 11s (just U-Boot), I re-write basing on linux I'm booting in arround
2s.

So I do not see the point to share the driver with u-boot, I prefer to have a
well writted one and optimised

Best Regards,
J.
> 
> Sascha
> 
> 
> -- 
> Pengutronix e.K.                           |                             |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
> Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |