[RFC 1/3] MIPS: add pre-bootloader (pbl) image support

Sascha Hauer s.hauer at pengutronix.de
Mon Nov 26 03:05:24 EST 2012


On Sat, Nov 24, 2012 at 07:45:01PM +0400, Antony Pavlov wrote:
> Sorry for delay.
> 
> On 20 November 2012 11:59, Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > On Sat, Nov 17, 2012 at 04:10:37PM +0400, Antony Pavlov wrote:
> >> This patch is based on ARM pbl support and allows
> >> creating a pre-bootloader binary for compressed image.
> >>
> >> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> >> ---
> >> +     .macro  ADR rd label temp
> >> +     .set    push
> >> +     .set    noreorder
> >> +     move    \temp, ra                       # preserve ra beforehand
> >> +     bal     _pc
> >> +      nop
> >
> > This file contains some whitespace damages you could cleanup along the
> > way.
> 
> If you are about this fragment
> >> +     bal     _pc
> >> +      nop
> 
> then there is no whitespace damage --- the 'nop' instruction is in the
> delay slot of the branch instruction (bal).

Ok, forget this one. I'm not familiar with Mips assembly.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list