[PATCH v3 1/3] ARM: Add CLPS711X architecture
s.hauer at pengutronix.de
Fri Nov 2 04:21:13 EDT 2012
On Fri, Nov 02, 2012 at 10:24:19AM +0400, Alexander Shiyan wrote:
> On Thu, 1 Nov 2012 08:32:51 +0100
> Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > On Thu, Nov 01, 2012 at 09:20:38AM +0400, Alexander Shiyan wrote:
> > > On Wed, 31 Oct 2012 22:36:08 +0100
> > > Sascha Hauer <s.hauer at pengutronix.de> wrote:
> > >
> > > ...
> > > > > +
> > > > > + asm("mov pc, #0");
> > > >
> > > > Or is it because you do not have a real reset function and have to jump
> > > > through zero instead? Still common_reset() shouldn't be necessary. What
> > > Yes.
> > > > you may have to do here is to make sure the MMU is disabled and caches
> > > > are flushed.
> > > Yes. This call was be added for do it.
> > > I may replace entrie function by calling start(). Is it a better way()?
> > arch_shutdown() should do it.
> Well, if there are no more comments for this series, I will create a v4 with
> one more forgotten fix for serial driver (IS_ERR clock check).
Fine, thanks. This should be the final one.
Two last things:
You should add pbl-y += lowlevel.o to your board Makefile. This allows
it to compile barebox as a compressed image.
You shouldn't have to overwrite env/bin/mtdparts-add. Instead this
should be called from env/init/mtdparts*
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox