[PATCH 0/2] Y-Modem implementation change

Robert Jarzmik robert.jarzmik at free.fr
Thu Nov 1 13:37:16 EDT 2012


Hi everyone,

This patchset aims at changing the Y-Modem protocol implementation.
You have already seen the RFC version, this is the next version, which :
 - provides a much more tested version
 - is ready for review

The following comments have been taken into account :
 - Antony: testing on a serial line
 - Sascha: split between protocol and commands
 - Jean-Christophe: kermit protocol change

So before doing the real review, could I ask of you :
 - Antony: could you redo your test over a serial line by applying only
           the first patch so that you can compare loady and loady2 ?
           Don't use "loady2 -g", as Y-Modem/G protocol requires a 
           lossless line (USB), and a serial line cannot guarantee it.
 - Sascha: does the split command/protocol suit you ?
 - Jean-Christophe: I left the loadb implementation as it is. The goal
                    of the patch is to change X-Modem and Y-Modem(G)
                    implementation, not kermit. Could you test that I
                    have not created a regression of loadb ?

Cheers.

--
Robert

Robert Jarzmik (2):
  commands: change Y-Modem implementation
  commands: remove old Y-Modem implementation

 commands/Makefile   |    4 +-
 commands/loadb.c    |  102 +------
 commands/loads.c    |    1 -
 commands/loadxy.c   |  238 ++++++++++++++++
 commands/xymodem.c  |  552 ++++++++++++++++++++++++++++++++++++
 commands/xyzModem.c |  785 ---------------------------------------------------
 include/xymodem.h   |   25 ++
 include/xyzModem.h  |  109 -------
 8 files changed, 826 insertions(+), 990 deletions(-)
 create mode 100644 commands/loadxy.c
 create mode 100644 commands/xymodem.c
 delete mode 100644 commands/xyzModem.c
 create mode 100644 include/xymodem.h
 delete mode 100644 include/xyzModem.h

-- 
1.7.10




More information about the barebox mailing list