[PATCH 2/2] Add FriendlyArm Tiny210 board (S5PV210)

[Alexey Galakhov]

On 25.05.2012 02:11, Sascha Hauer wrote:
> On Thu, May 24, 2012 at 07:27:45PM +0600, Alexey Galakhov wrote:
>> Signed-off-by: Alexey Galakhov <agalakhov at gmail.com>
>> ---
>> +
>> +#define ADDR_V210_SDMMC_BASE	0xD0037488
>> +#define ADDR_CopySDMMCtoMem	0xD0037F98
>> +
>> +#define RR(x) (*(volatile uint32_t*)(x))
>> +
> 
> why not use regular readl/writel here?

Ok. Aren't readl/writel for register access? This is "not a register"
(although there is in fact no differnce).

> Can we do without pll init? If not, the ifdef should not be here.

The PLL comes initialized in some way from the iROM boot. It may or may
not work depending on the hardware actually used. Looks like DRAM and
UART are OK but others may not work.

> Does it make sense to run this code without SDRAM setup code? It seems
> the ifdef should not be here. Without SDRAM setup code you'll jump to
> nirvana below.

Ok. Thanks.

> Please use DEVICE_ID_DYNAMIC instead of -1.

Ok, thanks.

Regards,
Alex