[PATCH] common: Make MENU depend on PROCESS_ESCAPE_SEQUENCE

Alan Ott alan at signal11.us
Mon May 21 23:35:02 EDT 2012


On 05/21/2012 10:40 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:
> Hi
>
> Please revert break my work on at91bootstrap where we use the menu without any shell support
>
> And the does work with or without hush support

Upon closer inspection, it should be:

     config MENU
     bool
     prompt "Menu Framework"
+    select PROCESS_ESCAPE_SEQUENCE if SHELL_HUSH

I have posted v2 which does this, and I agree that the original patch
should be reverted in favor of the new one.

Steps to reproduce on the master branch:

1. build on amd64 (no ARCH= or CROSS_COMPILE= or anything else)
2. make distclean
3. make menuconfig
4.    Select "Menu Framework" from General Settings
5.    leave everything else default.
6. make
7. output at [1] (link error).

Alan.

[1]
  LD      barebox
common/built-in.o: In function `print_menu_entry':
menu.c:(.text+0x5415): undefined reference to `process_escape_sequence'
common/built-in.o: In function `print_menu':
menu.c:(.text+0x54a3): undefined reference to `process_escape_sequence'
collect2: ld returned 1 exit status
make: *** [barebox] Error 1




More information about the barebox mailing list