[PATCH 12/16] fec_imx: restart aneg at open and not at init

[Sascha Hauer]

On Thu, May 17, 2012 at 09:32:57PM +0200, Eric Bénard wrote:
> Hi Sascha,
> 
> Le Thu, 17 May 2012 19:36:19 +0200,
> Sascha Hauer <s.hauer at pengutronix.de> a écrit :
> > On Thu, May 17, 2012 at 05:46:14PM +0200, Eric Bénard wrote:
> > > else we can get a 1 second timeout at each boot since
> > > "6cbecc4 net: miidev: properly check for MII reset"
> > 
> > I had this issue aswell on the babbage board. It turned out that this
> > was really an issue in the initialization order. On the babbage the fec
> > was registered before power was applied to the phy. Looking at the
> > eukrea mx51 code it seems that you reset the phy after you have
> > registered the fec. I suggest that you change the order instead of
> > applying this patch.
> > 
> in fact I met the problem on cpuimx25 & cpuimx35 (because a wrong PHY
> address was set in the board configuration) so I don't have the problem
> anymore.
> But I think launching the autonegotiation during the boot is not
> necessary and can be a source of time loss.

Maybe we should do some measurements. The original intention was that we
start autonegotiation during init time so that it is already done when
we actually use the device.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |