[PATCH] PCM970: Added support for CompactFlash

[Sascha Hauer]

On Tue, May 15, 2012 at 10:47:54PM +0400, Alexander Shiyan wrote:
> Added support for CompactFlash cards for PCM970 development board via
> PCMCIA window. Directly we cannot use this feature, because some signals
> connects to i.MX pins which cannot be configured as GPIO. This is first
> try to make this interface works, so comments are welcome.

What do you mean with "Directly we cannot use this feature"?

> 
> Hit any key to stop autoboot:  3
> barebox at Phytec phyCORE-i.MX27:/ mkdir /d
> barebox at Phytec phyCORE-i.MX27:/ mount /dev/disk0.0 fat /d
> barebox at Phytec phyCORE-i.MX27:/ ls /d
> test.txt

It seems to work fine here?

> +
> +#define PCMCIA_PIPR		__REG(IMX_PCMCIA_CTL_BASE + 0x00)
> +#define PCMCIA_PSCR		__REG(IMX_PCMCIA_CTL_BASE + 0x04)
> +#define PCMCIA_PER		__REG(IMX_PCMCIA_CTL_BASE + 0x08)
> +#define PCMCIA_PBR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x0c + ((x) << 2))
> +#define PCMCIA_POR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x28 + ((x) << 2))
> +#define PCMCIA_POFR(x)		__REG(IMX_PCMCIA_CTL_BASE + 0x44 + ((x) << 2))
> +#define PCMCIA_PGCR		__REG(IMX_PCMCIA_CTL_BASE + 0x60)
> +#define PCMCIA_PGSR		__REG(IMX_PCMCIA_CTL_BASE + 0x64)

Please don't use __REG. We should properly define the register addresses
and use writel/readl instead. I wanted to remove __REG stuff for longer
now, but never came to it.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |