[PATCH] dns: fix recursive loop
Sascha Hauer
s.hauer at pengutronix.de
Wed May 16 02:50:50 EDT 2012
resolv() uses getenv_ip() which in turn calls resolv(). Fix
this inifinite loop by not using getenv_ip directly.
Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
---
net/dns.c | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
diff --git a/net/dns.c b/net/dns.c
index e13d654..eb96c57 100644
--- a/net/dns.c
+++ b/net/dns.c
@@ -197,6 +197,7 @@ static void dns_handler(void *ctx, char *packet, unsigned len)
IPaddr_t resolv(char *host)
{
IPaddr_t ip;
+ const char *ns;
if (!string_to_ip(host, &ip))
return ip;
@@ -205,8 +206,14 @@ IPaddr_t resolv(char *host)
dns_state = STATE_INIT;
- ip = getenv_ip("net.nameserver");
- if (!ip)
+ ns = getenv("net.nameserver");
+ if (!ns || !*ns) {
+ printk("%s: no nameserver specified in $net.nameserver\n",
+ __func__);
+ return 0;
+ }
+
+ if (string_to_ip(ns, &ip))
return 0;
debug("resolving host %s via nameserver %s\n", host, ip_to_string(ip));
--
1.7.10
More information about the barebox
mailing list