[PATCH 3/9] Minimal S5PV210 + Tiny210 support (2nd stage only)
jbe at pengutronix.de
Mon May 14 05:57:29 EDT 2012
please keep the mailing list at least on CC.
Alexey Galakhov wrote:
> > It would be all right if you had introduce the basic support first and it
> > is now part of the repository. And *then* add the native boot support as
> > a really second step and separate patch series.
> The iROM support should be separated anyway. The reason is, iROM is only
> a temporary solution until we have a working replacement. This patch is
> designed to be easily reverted separately as soon as we'll able to boot
> without it.
> Using iROM to boot is generally a bad idea, but there's no alternative
> right now.
For you there might be no alternative right now. But for Barebox its all right
if only a basic support for this new CPU is available.
> I think the correct patch series should look like that:
> * make some space for everything (not introducing anything new, to be
> able to use git bisect if things do break)
> * add support of the new architecture to the existing code
> * add support for specific PLL
> * add support for specific DRAM
> * add support for iROM
Skip the iROM entirely in your patch series if you want to remove it later on.
What sense would it make to include it and then remove it again?
> * finally, add new board.
Yes. This step makes use of all the steps above (but not the iROM).
> The point is, if one reverts these patches one by one from the end, the
> rest will be usable.
There is almost _never_ a reason to revert a complete patch. If an older patch
has introduced a regression then there will be a new patch that fixes it and
explains why and how to fix.
> However, there's one bad thing: it's better to add at least one board to
> Kconfig with the new arch.
Pengutronix e.K. | Juergen Beisert |
Linux Solutions for Science and Industry | http://www.pengutronix.de/ |
More information about the barebox