[PATCH 1/2] i2c: Fix barebox crash when 'count' is not set for i2c_read command

[Sascha Hauer]

On Fri, May 11, 2012 at 07:42:18PM +0400, Alexander Shiyan wrote:
> Running i2c_read without the 'count' setting causes an error and reboots.
> 

Applied to master.

Thanks
 Sascha

> barebox at Phytec phyCORE-i.MX27:/ i2c_read -b 1 -a 0x4a -r 0x00
> ERROR: out of memory
> no stack data available
> ---
>  commands/i2c.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/commands/i2c.c b/commands/i2c.c
> index b3d09dc..39bae35 100644
> --- a/commands/i2c.c
> +++ b/commands/i2c.c
> @@ -170,7 +170,7 @@ static int do_i2c_read(int argc, char *argv[])
>  		}
>  	}
>  
> -	if ((addr < 0) || (reg < 0) || (count == 0) || (addr > 0x7F))
> +	if ((addr < 0) || (reg < 0) || (count < 1) || (addr > 0x7F))
>  		return COMMAND_ERROR_USAGE;
>  
>  	adapter = i2c_get_adapter(bus);
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |