[PATCH 3/4] mtd nand: add mxs-nand driver

Marek Vasut marex at denx.de
Fri Jun 8 11:06:13 EDT 2012


Dear Sascha Hauer,

> From: Wolfram Sang <w.sang at pengutronix.de>
> 
> Based on the U-Boot version. Changed to kernel style register layout, added
> MX23 support (WIP!), made MMU aware and adapted to barebox.

Can you split the changes so it's not such a block of code, hard to review ? 
Possibly to "kernel style register layout" (which I believe is stupid anyway, 
using struct based access is less error prone and more clear), "mx23 support" 
and "mmu awareness" (whatever that is).

> Signed-off-by: Marek Vasut <marek.vasut at gmail.com>
> Signed-off-by: Wolfram Sang <w.sang at pengutronix.de>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>

Best regards,
Marek Vasut



More information about the barebox mailing list