[PATCH 1/3] I.MX clko: Using strtol function instead strtoul for getting argument for clko source

Sascha Hauer s.hauer at pengutronix.de
Thu Jun 7 13:35:06 EDT 2012


On Thu, Jun 07, 2012 at 05:00:49PM +0400, Alexander Shiyan wrote:
> 
> Signed-off-by: Alexander Shiyan <shc_work at mail.ru>
> ---
>  arch/arm/mach-imx/clko.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>

Can you please add an explanation why this change is done? I assume that
-1 can be used to disable clko, but the commit log should mention this.

Sascha

> diff --git a/arch/arm/mach-imx/clko.c b/arch/arm/mach-imx/clko.c
> index 0e4fbcc..8e568d2 100644
> --- a/arch/arm/mach-imx/clko.c
> +++ b/arch/arm/mach-imx/clko.c
> @@ -14,7 +14,7 @@ static int do_clko(int argc, char *argv[])
>  			div = simple_strtoul(optarg, NULL, 0);
>  			break;
>  		case 's':
> -			src = simple_strtoul(optarg, NULL, 0);
> +			src = simple_strtol(optarg, NULL, 0);
>  			break;
>  		}
>  	}
> -- 
> 1.7.3.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list