Re[2]: [PATCH 1/6] mc13xxx: Define maximum SPI clock frequency global to driver

[Alexander Shiyan]

Hello.

Fri, 20 Jul 2012 10:11:36 +0200 от Sascha Hauer <s.hauer at pengutronix.de>:
> On Fri, Jul 20, 2012 at 12:05:21PM +0400, Alexander Shiyan wrote:
>  > > 
>  > > The values indeed look quite arbitrary, but it may be that a hardware
>  > > design does not support such high frequencies. Maybe better
>  > > 
>  > > if (!mc_dev->spi->max_speed_hz)
>  > > mc_dev->spi->max_speed_hz = 20000000
>  > > 
>  > > ?
>  > On my opinion, tests for supported speed, is work for SPI-driver, not for device driver.
>  > Is not it?
> 
>  So you mean that the i.MX spi drivers platform data should have a
>  maximum speed field instead of the client drivers? Sounds good.
>  In this case we can apply the patch.

No additional fields required. We are pass max_speed_hz option in the SPI-driver
to clock divider, so frequency cannot be higher than possible. Fixme.