[RFC 2/2] ARM omap: Add CONFIG_SILENT

Sascha Hauer s.hauer at pengutronix.de
Thu Jan 12 04:28:53 EST 2012


On Wed, Jan 11, 2012 at 11:04:44PM +0530, Sanjeev Premi wrote:
> Don't display any verbose message on the console.

We already have pr_info and friends which right now all fall
back to printf. Instead of adding an ifdef for each conditional
printf how about making pr_* configurable? Something like this:

#if (CONFIG_LOGLEVEL > 6)
#define pr_info(fmt, arg...) printf(fmt, ##arg)
#else
#define pr_info(fmt, arg...)	do {} while(0)
#endif
#if (CONFIG_LOGLEVEL > 5)
#define pr_notice(fmt, arg...)	printf(fmt, ##arg)
#else
#define pr_notice(fmt, arg...)    do {} while(0)
#endif

BTW you seem to be very concerned about the codesize in the xloader
environments, which I can understand. How about giving my thumb2 patches
a try?

panda_xload_defconfig:
-rwxr-xr-x 1 sha ptx 41272 Jan 12 10:25 barebox.bin

panda_xload_defconfig in thumb2 mode:
-rwxr-xr-x 1 sha ptx 30348 Jan 12 10:25 barebox.bin

To merge these I'm currently waiting for Jean-Christophes OK on

ARM: move exception vectors away from start of binary

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list