[PATCH v2 3/4] serial gadget: enable/disable on request

Sascha Hauer s.hauer at pengutronix.de
Wed Jan 4 03:57:42 EST 2012


On Wed, Jan 04, 2012 at 09:11:58AM +0100, Eric Bénard wrote:
> Hi Jean-Christophe,
> 
> Le Wed, 4 Jan 2012 09:00:43 +0100,
> Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com> a écrit :
> 
> > > +/*		case 'o':
> > > +			mode = 1;
> > > +			break;*/
> > ditto
> > > +/*BAREBOX_CMD_HELP_OPT  ("-o",   "CDC OBEX\n")*/
> > ditto
> 
> that's not an error, OBEX is currently present in serial.c but the
> necessary code is not yet in barebox, so I prepared the code for OBEX
> but comented it out everywhere.

Can you then please add a

/* OBEX support is missing in barebox */
/* #define HAVE_OBEX */

and ifdef the code relevant for OBEX? It makes it more clear why
this is commented out.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list