[PATCH 09/11] complete: add go and sleep support

[Jean-Christophe PLAGNIOL-VILLARD]

On 08:03 Mon 23 Apr     , Sascha Hauer wrote:
> On Thu, Apr 19, 2012 at 07:44:56AM +0200, Jean-Christophe PLAGNIOL-VILLARD wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  commands/go.c      |    2 ++
> >  commands/sleep.c   |    2 ++
> >  common/complete.c  |    5 +++++
> >  include/complete.h |    1 +
> >  4 files changed, 10 insertions(+), 0 deletions(-)
> > 
> > diff --git a/commands/go.c b/commands/go.c
> > index c821207..e9e9d40 100644
> > --- a/commands/go.c
> > +++ b/commands/go.c
> > @@ -25,6 +25,7 @@
> >  
> >  #include <common.h>
> >  #include <command.h>
> > +#include <complete.h>
> >  #include <fs.h>
> >  #include <fcntl.h>
> >  #include <linux/ctype.h>
> > @@ -91,4 +92,5 @@ BAREBOX_CMD_START(go)
> >  	.cmd		= do_go,
> >  	.usage		= "start application at address or file",
> >  	BAREBOX_CMD_HELP(cmd_go_help)
> > +	BAREBOX_CMD_COMPLETE(cammand_var_complete)
> >  BAREBOX_CMD_END
> > diff --git a/commands/sleep.c b/commands/sleep.c
> > index f772e87..c5f7867 100644
> > --- a/commands/sleep.c
> > +++ b/commands/sleep.c
> > @@ -22,6 +22,7 @@
> >  
> >  #include <common.h>
> >  #include <command.h>
> > +#include <complete.h>
> >  #include <clock.h>
> >  
> >  static int do_sleep(int argc, char *argv[])
> > @@ -46,4 +47,5 @@ static int do_sleep(int argc, char *argv[])
> >  BAREBOX_CMD_START(sleep)
> >  	.cmd		= do_sleep,
> >  	.usage		= "delay execution for n seconds",
> > +	BAREBOX_CMD_COMPLETE(cammand_var_complete)
> >  BAREBOX_CMD_END
> > diff --git a/common/complete.c b/common/complete.c
> > index 5213b10..9ecce25 100644
> > --- a/common/complete.c
> > +++ b/common/complete.c
> > @@ -193,6 +193,11 @@ int empty_complete(struct string_list *sl, char *instr)
> >  	return 1;
> >  }
> >  
> > +int cammand_var_complete(struct string_list *sl, char *instr)
> > +{
> > +	return 0;
> > +}
> 
> Two patches before this one you introduced empty_complete. This function
> does the same, except that it returns 0 instead of 1. The return value
> of the complete functions is never checked, so what is going on here?

the return value is checked.

no this different we return 0 as you can use env var complete

the empty_complete means no args.

Bst Regards,