[PATCH 1/2] cfi flash: Fix loop count calculation
Eric Bénard
eric at eukrea.com
Tue Apr 10 04:38:39 EDT 2012
Le Thu, 5 Apr 2012 10:59:14 +0200,
Sascha Hauer <s.hauer at pengutronix.de> a écrit :
> 'reduce the number of loops by the width of the port' means
> a simple len / width. Do not try to be clever by shifting
> and doing it wrong.
>
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
Tested-by: Eric Bénard <eric at eukrea.com>
> ---
> drivers/nor/cfi_flash_intel.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/nor/cfi_flash_intel.c b/drivers/nor/cfi_flash_intel.c
> index 6318cfe..f0cbf72 100644
> --- a/drivers/nor/cfi_flash_intel.c
> +++ b/drivers/nor/cfi_flash_intel.c
> @@ -68,7 +68,7 @@ static int intel_flash_write_cfibuffer (struct flash_info *info, ulong dest, con
> return retcode;
>
> /* reduce the number of loops by the width of the port */
> - cnt = len >> (info->portwidth - 1);
> + cnt = len / width;
>
> flash_write_cmd(info, sector, 0, (u32)cnt - 1);
> while (cnt-- > 0) {
More information about the barebox
mailing list