[PATCH for next] 'bootz' command fails to load the zImage's header

Sascha Hauer s.hauer at pengutronix.de
Fri Oct 14 08:16:52 EDT 2011


On Fri, Oct 14, 2011 at 02:11:28PM +0200, Juergen Beisert wrote:
> Running the 'bootz' command always fails with
> 
> could not read <some file>
> 
> due to it loads only a size of a pointer, instead of the size of the expected
> header structure.

Applied to master instead which also has this bug. Unfortunately this
bug is also in the october release.

Sascha

> 
> Signed-off-by: Juergen Beisert <jbe at pengutronix.de>
> 
> diff --git a/arch/arm/lib/bootz.c b/arch/arm/lib/bootz.c
> index fc14487..9be615b 100644
> --- a/arch/arm/lib/bootz.c
> +++ b/arch/arm/lib/bootz.c
> @@ -53,7 +53,7 @@ static int do_bootz(struct command *cmdtp, int argc, char *argv[])
>  
>  	if (!usemap) {
>  		header = &__header;
> -		ret = read(fd, header, sizeof(header));
> +		ret = read(fd, header, sizeof(*header));
>  		if (ret < sizeof(*header)) {
>  			printf("could not read %s\n", argv[1]);
>  			goto err_out;
> 
> -- 
> Pengutronix e.K.                              | Juergen Beisert             |
> Linux Solutions for Science and Industry      | http://www.pengutronix.de/  |
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list