[PATCH 1/2] Add Altera Nios2 arch support

Sascha Hauer s.hauer at pengutronix.de
Fri Mar 18 03:49:01 EDT 2011


On Thu, Mar 17, 2011 at 05:50:09PM +0100, Franck JULLIEN wrote:
> Hi Sascha,
> 
> 2011/3/16 Sascha Hauer <s.hauer at pengutronix.de>
> 
> > Hi Julien,
> >
> >
> Well....it's Franck ;) I know that's a bit confusing......

Oops, sorry

> > > +#ifndef _BAREBOX_H_
> > > +#define _BAREBOX_H_  1
> > > +
> > > +typedef struct bd_info {
> > > +     int bi_baudrate;                /* serial console baudrate */
> > > +     unsigned long bi_ip_addr;       /* IP Address */
> > > +     unsigned char bi_enetaddr[6];   /* Ethernet adress */
> > > +     unsigned long bi_arch_number;   /* unique id for this board */
> > > +     unsigned long bi_boot_params;   /* where this board expects params
> > */
> > > +     unsigned long bi_memstart;      /* start of DRAM memory */
> > > +     unsigned long bi_memsize;       /* size  of DRAM memory in bytes */
> > > +     unsigned long bi_flashstart;    /* start of FLASH memory */
> > > +     unsigned long bi_flashsize;     /* size  of FLASH memory */
> > > +     unsigned long bi_flashoffset;   /* reserved area for startup
> > monitor */
> > > +} bd_t;
> >
> > This isn't used anywhere in this patch. Is it needed for passing data to
> > Linux? If yes, ok, otherwise please remove it.
> >
> 
> This file is included bu include/common.h
> Should I provide an empty file ?

Yes, please.

(As this seems only be used on ppc we should probably remove the
inclusion from common.h and include asm/barebox.h where necessary)

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list