[PATCH 00/54] New arch (NIOS2)

Sascha Hauer s.hauer at pengutronix.de
Fri Mar 4 03:45:33 EST 2011

Hi Franck,

On Thu, Mar 03, 2011 at 11:58:14PM +0100, franck.jullien at gmail.com wrote:
> From: Franck JULLIEN <franck.jullien at gmail.com>
> This is the base files of the Nios2 port. Almost everything is comming from u-boot.
> When those files are acked, I'll post drivers and utility commands.

Soo many patches ;). You can safely combine all these into two
patches, one for the nios2 support and one for the generic board.
The patches are only useful as a whole anyway, so no need to split
them up that fine. You will hit the list limit, so give me some time
to go to the moderator interface and and it through.

I'm not through all patches, but some remarks here:

There is some whitespace damage all around like spaces which should be
tabs. Also, please do not use direct pointer derefs to access registers.
You should use readl/writel accessors for them.

Thanks for doing this work. Although I don't have a nios baord, I really
appreciate extending barebox to more architectures.


Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

More information about the barebox mailing list