[PATCH 2/2] startup.c: make DEBUG_LL output more useful

Sascha Hauer s.hauer at pengutronix.de
Mon Jul 18 02:46:26 EDT 2011


On Sun, Jul 17, 2011 at 10:56:25PM +0400, Antony Pavlov wrote:
> Signed-off-by: Antony Pavlov <antonynpavlov at gmail.com>
> ---
>  common/startup.c |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/common/startup.c b/common/startup.c
> index 00bc9a0..f8efa08 100644
> --- a/common/startup.c
> +++ b/common/startup.c
> @@ -134,13 +134,17 @@ void start_barebox (void)
>  
>  	for (initcall = __barebox_initcalls_start;
>  			initcall < __barebox_initcalls_end; initcall++) {
> +		PUTS_LL("<<");
>  		PUTHEX_LL(*initcall);
> -		PUTC_LL('\n');
>  		result = (*initcall)();
> +		PUTC_LL('>');
>  		if (result)
>  			hang();
> +		PUTS_LL(">\r\n");

Looks mostly good. Can we to the \n -> \r\n conversion in PUTS_LL
instead?

Sascha

>  	}
>  
> +	PUTS_LL("initcalls done\r\n");
> +
>  	display_meminfo();
>  
>  #ifdef CONFIG_ENV_HANDLING
> -- 
> 1.7.5.4
> 
> 
> _______________________________________________
> barebox mailing list
> barebox at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/barebox
> 

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the barebox mailing list