MAKEALL problem

[Belisko Marek]

On Fri, Apr 29, 2011 at 11:30 AM, Jean-Christophe PLAGNIOL-VILLARD
<plagnioj at jcrosoft.com> wrote:
> On 10:47 Fri 29 Apr     , Belisko Marek wrote:
>> HI,
>>
>> On Fri, Apr 29, 2011 at 10:25 AM, Jean-Christophe PLAGNIOL-VILLARD
>> <plagnioj at jcrosoft.com> wrote:
>> > On 09:06 Fri 29 Apr     , Belisko Marek wrote:
>> >> Hi,
>> >>
>> >> current HEAD: 165a1e91f9178f160bc34c00e1d5b356cf022a00 make this problem:
>> >>
>> >> CROSS_COMPILE=arm-none-linux-gnueabi- ARCH=arm ./MAKEALL
>> >> Building arm a9m2410_defconfig
>> >> Configure: ./MAKEALL: 266: Bad substitution
>> >>
>> >> --------------------- SUMMARY ----------------------------
>> >> defconfigs compiled: 0
>> >> compiled in   10s
>> >> ----------------------------------------------------------
>> >>
>> >> Am I missing something or it's really broken?
>> > no I use it evreyday on barebox or linux
>> >
>> > which shell are you using
>> GNOME Terminal 2.32.1
> it's your terminal
>
> which shell sh/bash/dash/others?
After some googling and check MAKEALL with checkbashism script this
patch fix my problem (work fine on Ubuntu):

1. PIPESTATUS is bashism but hard to replace with something valuable in dash
s ojust remove bash array handling

2. source is also bashism. fix it with . replacement.

diff --git a/MAKEALL b/MAKEALL
index e987de2..6c0d017 100755
--- a/MAKEALL
+++ b/MAKEALL
@@ -77,7 +77,7 @@ stats() {
 }

 check_pipe_status() {
-       for i in "${PIPESTATUS[@]}"
+       for i in ${PIPESTATUS}
        do
                [ $i -gt 0 ] && return 1
        done
@@ -234,7 +234,7 @@ then
                CONFIG="./${CONFIG}"
        fi

-       source "${CONFIG}"
+       . "${CONFIG}"
 fi

 [ -d "${LOGDIR}" ] || mkdir ${LOGDIR} || exit 1


>
> Best Regards,
> J.
>

regards,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com