[PATCH] i2c-imx: wait for STOP before disabling controller
Jean-Christophe PLAGNIOL-VILLARD
plagnioj at jcrosoft.com
Thu Sep 30 23:29:54 EDT 2010
On 13:22 Fri 01 Oct , Marc Reilly wrote:
> Makes sure that the STOP condition is transmitted before the I2C
> controller is disabled.
> This fixes a problem where writing to an external EEPROM was not working
> because the EEPROM waits until the STOP before initiating the write
> internally.
>
> Signed-off-by: Marc Reilly <marc at cpdesign.com.au>
> ---
> drivers/i2c/i2c-imx.c | 10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/i2c-imx.c b/drivers/i2c/i2c-imx.c
> index cc64d94..3e37441 100644
> --- a/drivers/i2c/i2c-imx.c
> +++ b/drivers/i2c/i2c-imx.c
> @@ -265,7 +265,9 @@ static void i2c_imx_stop(struct i2c_adapter *adapter)
> temp = readb(base + IMX_I2C_I2CR);
> temp &= ~(I2CR_MSTA | I2CR_MTX);
> writeb(temp, base + IMX_I2C_I2CR);
> - i2c_imx->stopped = 1;
> + /* wait for the stop condition to be send, otherwise the i2c
> + * controller is disabled before the STOP is sent completely */
> + i2c_imx->stopped = i2c_imx_bus_busy(adapter,0) ? 0 : 1;
please add a space after the ","
Best Regards,
J.
More information about the barebox
mailing list