[PATCHv2] Add dynamic video initialization to barebox

Sascha Hauer s.hauer at pengutronix.de
Mon Nov 1 09:19:46 EDT 2010

Hi Jürgen,

On Tue, Oct 26, 2010 at 01:31:36PM +0200, Juergen Beisert wrote:
> Currently barebox uses a fixed videomode setup. Everything is compiled in.
> This change adds the possibility to select a videomode according to a
> connected display at runtime. The current behaviour is still present if not
> otherwise configured. If configured for runtime setup, initialization of the
> video hardware will be delayed until the required videomode will be selected
> from the shell code. If more than one videomode is supported by the platform,
> running the 'devinfo' command on the framebuffer device shows the supported
> videomode list. After selecting the videomode, the output can be enabled.

General remarks about this series:

- Please do not add code with '#if 0' and activate it later. This shows
  the series has the wrong order.
- Please refrain from basing your internal functions around 'struct
  device_d'. By doing so we completey lose type safety and at least in
  case of the mci framework where three different devices are involved
  this leads to unreadable and error prone code. The framebuffer
  code should be based around struct fb_info.
- Please keep the line lengths within sensible limits.
- Get rid of CONFIG_VIDEO_DELAY_INIT and make the mode runtime
  changeable. All this requires is a
  host->fb_disable(info); host->fb_mode(info, newmode); host->fb_enable(mode);


Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

More information about the barebox mailing list