[PATCH 00/13] Clean malloc() implementation
s.hauer at pengutronix.de
Tue Nov 24 03:55:00 EST 2009
On Mon, Nov 23, 2009 at 11:24:44AM +0100, Alessandro Rubini wrote:
> > This patch set tries to clean up the current malloc source code to get rid of
> > all the ugly and unused code in these files.
> However, this is dlmalloc, i.e. an independently-developed package,
> that is still evolving independently.
> While I agree it's suboptimal per our standards, I think not diverging
> from upstream is useful, more than cleaning up this source.
> IIRC u-boot-v1 currently moved to a newer and faster version of
> dlmalloc (or at least this has been discussed). A similar move would
> either be inhibited by your cleanup or it will just discard all your
> cleanup work (so you'd better have saved that time).
They haven't done this yet.
> So unless your cleanup fixes real bugs, I'd better leave dlmalloc as
> it is, but I'm aware it's not my call.
I haven't touched this file for the same reason. On the other hand the
original code diverged so much from ours that we would replace it
completely with the new version. In this case it wouldn't matter *what*
we replace with the new version. So Jürgens patches shouldn't hurt us. I
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
More information about the barebox