Robert P. J. Day rpjday at crashcourse.ca
Wed Dec 23 04:06:00 EST 2009

On Wed, 23 Dec 2009, Sascha Hauer wrote:

> Hi Robert,
> On Tue, Dec 22, 2009 at 09:51:19AM -0500, Robert P. J. Day wrote:
> >
> > Signed-off-by: Robert P. J. Day <rpjday at crashcourse.ca>
> >
> > ---
> >
> >   while this fixes an obvious typo in this file, it's really just
> > a band-aid since this header file sets *numerous* CONFIG_-prefixed
> > macros, which it shouldn't be doing.  any macros prefixed with
> > CONFIG_ should be reserved for the Kconfig namespace, so it
> > wouldn't hurt to apply this patch, but it's clear that this file
> > needs a lot more work at some point in the future.
> I used the eco920 during early development. We maybe have the
> opportunity to work on this board in the next time and then I'll fix
> this. Otherwise I tend to remove the board completely.

  no problem.  don't think you need to explain dropping any patch
submissions from me -- obviously, i don't know the history of the
software.  whatever you decide.


Robert P. J. Day                               Waterloo, Ontario, CANADA

            Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

More information about the barebox mailing list