more CONFIG oddities in the current barebox tree

[Sascha Hauer]

On Sun, Dec 20, 2009 at 07:08:02AM -0500, Robert P. J. Day wrote:
> 
>   here's a short list of Makefile CONFIG tests that test for
> non-existent CONFIG variables -- not strictly an error, just valueless
> and can be removed if there's no compelling reason to keep them.  (as
> always, could be trivial false positives).
> 
> ===== CMD_I2C =====
> ./commands/Makefile:obj-$(CONFIG_CMD_I2C)		+= i2c.o

This can be removed.

> ===== LOGO =====
> ./scripts/Makefile:hostprogs-$(CONFIG_LOGO)         += pnmtologo

Ditto

> ===== MODULE =====
> ./common/Makefile:obj-$(CONFIG_MODULE)		+= module.o
> ./arch/ppc/Makefile:ifndef CONFIG_MODULE

Ditto. This is a duplicate of CONFIG_MODULES.

> ===== MODVERSIONS =====
> ./Makefile:  KBUILD_BUILTIN := $(if $(CONFIG_MODVERSIONS),1)
> ./scripts/Makefile:#subdir-$(CONFIG_MODVERSIONS) += genksyms


> ===== PROM_CONSOLE =====
> ./scripts/Makefile:hostprogs-$(CONFIG_PROM_CONSOLE) += conmakehash

Can be removed.

> ===== SIMPLE_PARSER =====
> ./commands/Makefile:obj-$(CONFIG_SIMPLE_PARSER)	+= setenv.o

should be CONFIG_SHELL_SIMPLE instead.

> ===== USE_IRQ =====
> ./arch/ppc/mach-mpc5xxx/Makefile:obj-$(CONFIG_USE_IRQ)	+=
> interrupts.o
> ./arch/ppc/lib/Makefile:obj-$(CONFIG_USE_IRQ) += interrupts.o

The IRQ stuff is an area for some more cleanup. So far I do not use
interrupts at all and I doubt they are working anywhere. Maybe it's best
to keep it like it is until somebody is willing to think about irqs and
has some suggestions in which direction we want to go.

> ===== VT =====
> ./scripts/Makefile:hostprogs-$(CONFIG_VT)           += conmakehash

Can be removed.

> 
>   if any of that can be obviously deleted, let me know and i can
> submit the appropriate patches.

That would be great. Your scripts really put the eyes on some long
forgotten things ;)

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |