[PATCH] cramfs: probe(): fix cdev lookup

Peter Korsgaard jacmet at sunsite.dk
Tue Dec 15 15:33:31 EST 2009


>>>>> "Marc" == Marc Kleine-Budde <mkl at pengutronix.de> writes:

Hi,

 >> @@ -431,7 +431,7 @@ static int cramfs_probe(struct device_d *dev)
 >> if (strncmp(fsdev->backingstore, "/dev/", 5))
 >> return -ENODEV;
 >> 
 >> -	priv->cdev = cdev_by_name(fsdev->backingstore);
 >> +	priv->cdev = cdev_by_name(fsdev->backingstore + 5);

 Marc> IMHO sizeof("/dev/") (and perhaps a comment) make the code more readable.

That would be sizeof("/dev/") - 1 to not count in the trailing 0.  The
same should presumably also be done in the strncmp above - I don't find
the sizeof - 1 syntax particular more readable, but I can change it if
preferred.

-- 
Bye, Peter Korsgaard




More information about the u-boot-v2 mailing list