[PATCH] b43: Fix bogus compilation warning for phy_n

Rafał Miłecki zajec5 at gmail.com
Thu May 19 17:43:06 EDT 2011

2011/5/19 Larry Finger <Larry.Finger at lwfinger.net>:
> When cross-compiling the 2.6.39 wireless-testing source using GCC version
> (SUSE Linux) 4.3.2 [gcc-4_3-branch revision 141291] on an x86_64 system,
> the following warning is issued:
>  CC [M]  drivers/net/wireless/b43/phy_n.o
> drivers/net/wireless/b43/phy_n.c: In function ‘b43_nphy_cal_tx_iq_lo’:
> drivers/net/wireless/b43/phy_n.c:3096: warning: ‘last’ may be used
>        uninitialized in this function
> A quick look at the code shows that the warning is bogus and a gcc bug,
> but to ensure clean compilation for all users, mark the offending variable
> as uninitialized.

Did you check for both "last" usages on this function? From my quick
review it seems "last" is set in case of
1) mphase_cal_phase_id > 2
2) b43_nphy_tx_tone returning success

I'm not so sure if this patch is correct.


More information about the b43-dev mailing list