[PATCH 2/4] bcma: allow setting FAST clockmode for a core

John W. Linville linville at tuxdriver.com
Tue Jul 19 17:09:14 EDT 2011


On Tue, Jul 19, 2011 at 10:54:32PM +0200, Rafał Miłecki wrote:
> W dniu 19 lipca 2011 22:50 użytkownik Rafał Miłecki <zajec5 at gmail.com> napisał:
> > W dniu 19 lipca 2011 22:42 użytkownik John W. Linville
> > <linville at tuxdriver.com> napisał:
> >>  CC [M]  drivers/bcma/core.o
> >> drivers/bcma/core.c: In function ‘bcma_core_set_clockmode’:
> >> drivers/bcma/core.c:65:22: error: ‘BCMA_CLKCTLST’ undeclared (first use in this function)
> >> drivers/bcma/core.c:65:22: note: each undeclared identifier is reported only once for each function it appears in
> >> drivers/bcma/core.c:65:73: error: ‘BCMA_CLKCTLST_FORCEHT’ undeclared (first use in this function)
> >> drivers/bcma/core.c:69:8: error: ‘BCMA_CLKCTLST_HAVEHT’ undeclared (first use in this function)
> >> drivers/bcma/core.c: In function ‘bcma_core_pll_ctl’:
> >> drivers/bcma/core.c:89:35: error: ‘BCMA_CLKCTLST_EXTRESREQ’ undeclared (first use in this function)
> >> drivers/bcma/core.c:90:38: error: ‘BCMA_CLKCTLST_EXTRESST’ undeclared (first use in this function)
> >> drivers/bcma/core.c:93:22: error: ‘BCMA_CLKCTLST’ undeclared (first use in this function)
> >> make[2]: *** [drivers/bcma/core.o] Error 1
> >> make[1]: *** [drivers/bcma] Error 2
> >> make: *** [drivers] Error 2
> >
> > I'm sorry, that's quite normal you could lost order&dependency with
> > the amount of patches I've sent.
> >
> > As nobody objected, please apply
> > [RFC][PATCH] bcma: move define of BCMA_CLKCTLST register
> > It should be applied before this one.
> 
> Could I do something to avoid such a problems in the future?
> 
> Should I put info about dependency in cover-letter? Should I create
> own git tree? Should I slow down with sending patches (doing more of
> them before sending)?

It is always good to indicate dependencies, especially on patches
posted in a different series or when the dependency is on a patch
posted as RFC.

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville at tuxdriver.com			might be all we have.  Be ready.



More information about the b43-dev mailing list