[PATCH] Fix alignment issues with DMA TX on BCM4331

David Woodhouse dwmw2 at infradead.org
Sat Aug 13 18:17:14 EDT 2011


On Sun, 2011-08-14 at 00:12 +0200, Rafał Miłecki wrote:
> I've just checked wl and they don't do that anyway. The keep order
> depending on the alignment bool. 

Ah, OK. So they still write TXCTL first, if the device can't support
unaligned descriptors?

The brcm80211 driver doesn't; it writes TXCTL last, unconditionally.

Do you want me to send another patch which makes it conditional? It
complicates the code with something that might be unnecessary legacy
baggage... but means we don't have to be worried about regressions on
older hardware.

-- 
dwmw2




More information about the b43-dev mailing list