[PATCH] Fix alignment issues with DMA TX on BCM4331

Rafał Miłecki zajec5 at gmail.com
Sat Aug 13 18:12:01 EDT 2011


W dniu 14 sierpnia 2011 00:07 użytkownik David Woodhouse
<dwmw2 at infradead.org> napisał:
> On Sun, 2011-08-14 at 00:02 +0200, Rafał Miłecki wrote:
>> W dniu 13 sierpnia 2011 23:57 użytkownik Larry Finger
>> <Larry.Finger at lwfinger.net> napisał:
>> >> +
>> >> +                       b43_dma_write(ring, B43_DMA64_TXRINGLO, 0xff0);
>> >
>> > Should there be a new symbol rather than this magic number?
>
> Probably not. We're testing whether it stores certain bits of the
> address, or if the low 12 bits of the register are just hard-coded to
> zero. The raw value 0xff0 conveys that as well as any macro name that I
> could think of.
>
>> > Tested on BCM4318 on 32-bit system.
>>
>> The question is if your card supports unaligned (and as result, if you
>> tested it at all)
>
> Either way, he confirmed that writing TXCTL last works.

I've just checked wl and they don't do that anyway. The keep order
depending on the alignment bool.

-- 
Rafał



More information about the b43-dev mailing list