[PATCH] ssb: workarounds: be verbose about hacking SPROM revision, don't duplicate code

Michael Büsch mb at bu3sch.de
Wed Nov 3 17:43:45 EDT 2010


On Wed, 2010-11-03 at 22:06 +0100, Rafał Miłecki wrote: 
> +	default:
> +		ssb_printk(KERN_WARNING PFX "Unsupported SPROM"
> +			   "  revision %d detected. Will extract"
> +			   " v1\n", out->revision);
> +		out->revision = 1;
> +		sprom_extract_r123(out, in);

I think we should change this to throw a hard error if the sprom is
unknown. Extracting r123 is unlikely to do any good these days.
This workaround was only useful back in the days where 95% of the
cards out there were r123. But today that's not the case.

> 	}
>  
>  	if (out->boardflags_lo == 0xFFFF)


-- 
Greetings Michael.




More information about the b43-dev mailing list