[PATCH 2/4] b43: N-PHY: implement radio 2056 init steps
Rafał Miłecki
zajec5 at gmail.com
Tue Dec 21 07:20:57 EST 2010
W dniu 21 grudnia 2010 12:34 użytkownik Michael Büsch <mb at bu3sch.de> napisał:
> On Tue, 2010-12-21 at 11:50 +0100, Rafał Miłecki wrote:
>> +static void b43_radio_init2056_post(struct b43_wldev *dev)
>> +{
>> + b43_radio_set(dev, B2056_SYN_COM_CTRL, 0xB);
>> + b43_radio_set(dev, B2056_SYN_COM_PU, 0x2);
>> + b43_radio_set(dev, B2056_SYN_COM_RESET, 0x2);
>> + mdelay(1);
>
> Please don't use mdelay() ever. The driver is fully preemptible.
> Use msleep() instead.
So, using "msleep" allows kernel to switch context, while using
"mdelay" does not?
If so, should be convert our longer udelay calls (like 300us) to usleep?
--
Rafał
More information about the b43-dev
mailing list