[PATCH 2/4] b43: N-PHY: implement radio 2056 init steps

Michael Büsch mb at bu3sch.de
Tue Dec 21 06:34:33 EST 2010


On Tue, 2010-12-21 at 11:50 +0100, Rafał Miłecki wrote: 
> +static void b43_radio_init2056_post(struct b43_wldev *dev)
> +{
> +	b43_radio_set(dev, B2056_SYN_COM_CTRL, 0xB);
> +	b43_radio_set(dev, B2056_SYN_COM_PU, 0x2);
> +	b43_radio_set(dev, B2056_SYN_COM_RESET, 0x2);
> +	mdelay(1);

Please don't use mdelay() ever. The driver is fully preemptible.
Use msleep() instead.

-- 
Greetings Michael.




More information about the b43-dev mailing list