[PATCH v4 03/11] wifi: ath12k: WMI support to process EHT capabilities

[Aloka Dixit]

On 6/16/2023 3:50 AM, Wen Gong wrote:
> On 6/15/2023 7:49 PM, Kalle Valo wrote:
>> Aloka Dixit <quic_alokad at quicinc.com> writes:
>>
>>> Add WMI support to process the EHT capabilities passed by
>>> the firmware. Add required EHT specific definitions in
>>> structures ath12k_band_cap and ath12k_wmi_svc_rdy_ext_parse.
>>>
>>> For single_pdev chip such as WCN7850, only one pdev is created
>>> and only one hardware is registered to mac80211. This one pdev
>>> manages both 2.4 GHz radio and 5 GHz/6 GHz radio.
>>>
>>> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
>>> Tested-on: WCN7850 hw2.0 PCI 
>>> WLAN.HMT.1.0-03427-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.15378.4
>>> Signed-off-by: Aloka Dixit <quic_alokad at quicinc.com>
>>> Co-developed-by: Pradeep Kumar Chitrapu <quic_pradeepc at quicinc.com>
>>> Signed-off-by: Pradeep Kumar Chitrapu <quic_pradeepc at quicinc.com>
>>> Co-developed-by: Wen Gong <quic_wgong at quicinc.com>
>>> Signed-off-by: Wen Gong <quic_wgong at quicinc.com>
>> [...]
>>
>>> +struct ath12k_fw_pdev {
>>> +    u32 pdev_id;
>>> +    u32 phy_id;
>>> +    u32 supported_bands;
>>> +};
>> So we have now two very similar structures, ath12k_pdev and
>> ath12k_fw_pdev. It would be good to document above the structs their
>> purpose. Any ideas what I could add?
> 
> For single_pdev, the ath12k_pdev is always one pdev.
> 
> and ath12k_fw_pdev is more than one for single_pdev.
> 
>>

Okay will add a comment in the next version.