[PATCH v3 1/4] net: qrtr: Allow the host QRTR to assign a unique node id

Manivannan Sadhasivam mani at kernel.org
Thu Oct 22 10:41:25 PDT 2026


On Fri, Sep 25, 2026 at 07:43:02AM +0000, netdev-bot+sashiko at kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 2 · Medium: 1 · Low: 1
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] qrtr_endpoint_post() (net/qrtr/af_qrtr.c:570) replaces the
>   previously unconditional `qrtr_node_assign(node, cb->src_node)` with…
> - [High] net: qrtr: bypass of node ID rewrite for short DEL_CLIENT
>   packets
> - [Medium] The lazy initialization of node->ep_nid in
>   qrtr_endpoint_post() is an unlocked test-and-set: `if (node->ep_nid ==…
> - [Low] The new gate `if (node->nid == QRTR_EP_NID_AUTO || node->nid ==
>   cb->src_node)` at af_qrtr.c:570 reads node->nid with plain loads…
> 

These comments are addressed in v4.

pw-bot: cr

- Mani

-- 
மணிவண்ணன் சதாசிவம்



More information about the ath11k mailing list