[PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization
Rahul Bhattacharjee
quic_rbhattac at quicinc.com
Fri Oct 28 03:49:29 PDT 2022
On 10/28/2022 4:14 PM, Kalle Valo wrote:
> "Joseph S. Barrera III" <joebar at chromium.org> writes:
>
>> On 10/21/22 2:01 AM, Rahul Bhattacharjee wrote:
>>
>>> },
>>> + {/* end of list */}
>>> };
>> Do you want to add a comma after that last list element?
> I can add that in the pending branch.
>
>> Actually, I normally see the last list element simply being
>>
>>> + {},
>> ... with no comment necessary.
> I would prefer to have a comment to make it more visible that an empty
> element is needed at the end, but I would add that outside of braces?
>
> /* end of list */
> {},
>
> Thoughts? I can change this in the pending branch.
LGTM!
More information about the ath11k
mailing list