[PATCH] wifi: ath11k: Fix qmi_msg_handler data structure initialization
Kalle Valo
kvalo at kernel.org
Fri Oct 28 03:44:09 PDT 2022
"Joseph S. Barrera III" <joebar at chromium.org> writes:
> On 10/21/22 2:01 AM, Rahul Bhattacharjee wrote:
>
>> },
>> + {/* end of list */}
>> };
>
> Do you want to add a comma after that last list element?
I can add that in the pending branch.
>
> Actually, I normally see the last list element simply being
>
>> + {},
>
> ... with no comment necessary.
I would prefer to have a comment to make it more visible that an empty
element is needed at the end, but I would add that outside of braces?
/* end of list */
{},
Thoughts? I can change this in the pending branch.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
More information about the ath11k
mailing list