[PATCH v3 2/3] ath11k: Refactor update channel list function

Wen Gong quic_wgong at quicinc.com
Tue Nov 23 23:48:03 PST 2021


On 11/24/2021 3:39 PM, Kalle Valo wrote:
> Wen Gong <quic_wgong at quicinc.com> writes:
>
>> On 10/22/2021 8:37 PM, P Praneesh wrote:
>>
>> ...
>>
>>> ---
>>> ...
>>> -			ch->maxpower = channel->max_power * 2;
>>> -			ch->maxregpower = channel->max_reg_power * 2;
>>> -			ch->antennamax = channel->max_antenna_gain * 2;
>>> ...
>>>    +int ath11k_wmi_update_scan_chan_list(struct ath11k *ar,
>>> +				     struct scan_req_params *arg)
>>> ...
>>> +			ch->maxpower = channel->max_power;
>>> +			ch->maxregpower = channel->max_reg_power;
>>> +			ch->antennamax = channel->max_antenna_gain;
>>> +
>>> ...
>> I see it also have another patch to remove the "*2" for power.
>> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=9212c1b9e80a869e732769a4fe7f82d392b219be
>>
>> ath11k: send proper txpower and maxregpower values to firmware.
>>
>> so are you the same reason to remove "*2" ?
> I'm not quite getting what you are saying, can you elaborate more? Did
> this patch break something?

Oh. Not see break anything.

I just want to know why remove the "*2". Did you see any issue if NOT 
remove "*2"?

>



More information about the ath11k mailing list