[PATCH v3 2/3] ath11k: Refactor update channel list function

Kalle Valo kvalo at codeaurora.org
Tue Nov 23 23:39:50 PST 2021


Wen Gong <quic_wgong at quicinc.com> writes:

> On 10/22/2021 8:37 PM, P Praneesh wrote:
>
> ...
>
>> ---
>> ...
>> -			ch->maxpower = channel->max_power * 2;
>> -			ch->maxregpower = channel->max_reg_power * 2;
>> -			ch->antennamax = channel->max_antenna_gain * 2;
>> ...
>>   +int ath11k_wmi_update_scan_chan_list(struct ath11k *ar,
>> +				     struct scan_req_params *arg)
>> ...
>> +			ch->maxpower = channel->max_power;
>> +			ch->maxregpower = channel->max_reg_power;
>> +			ch->antennamax = channel->max_antenna_gain;
>> +
>> ...
>
> I see it also have another patch to remove the "*2" for power.
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?id=9212c1b9e80a869e732769a4fe7f82d392b219be
>
> ath11k: send proper txpower and maxregpower values to firmware.
>
> so are you the same reason to remove "*2" ?

I'm not quite getting what you are saying, can you elaborate more? Did
this patch break something?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches



More information about the ath11k mailing list