[PATCH] ath10k: Replace bit shifts with the BIT() macro for rx desc bits

Govind Singh govinds at codeaurora.org
Wed May 9 02:35:57 PDT 2018


On 2018-05-09 13:10, Marcus Folkesson wrote:
> Hello Govind,
> 
> On Wed, May 09, 2018 at 10:18:04AM +0530, Govind Singh wrote:
>> Use the BIT() macro from 'linux/bitops.h' to define the rx desc
>> bit flags to have consistency with new definitions.
>> 
>> Signed-off-by: Govind Singh <govinds at codeaurora.org>
>> ---
>>  drivers/net/wireless/ath/ath10k/rx_desc.h | 134 
>> +++++++++++-----------
>>  1 file changed, 67 insertions(+), 67 deletions(-)
>> 
>> diff --git a/drivers/net/wireless/ath/ath10k/rx_desc.h 
>> b/drivers/net/wireless/ath/ath10k/rx_desc.h
>> index 545deb6d7af1..b3d7c6e7ac90 100644
>> --- a/drivers/net/wireless/ath/ath10k/rx_desc.h
>> +++ b/drivers/net/wireless/ath/ath10k/rx_desc.h
> 
> Looks good, but please include linux/bitops.h as well.
> 
> From the documentation [1]:
> 
> If you use a facility then #include the file that defines/declares
>  that facility.  Don't depend on other header files pulling in ones
>  that you use.
> 

Thanks, addressed the comment in v2 patchset.

> 
> [1] Documentation/process/submit-checklist.rst
> 
> 
> Best regards
> Marcus Folkesson



More information about the ath10k mailing list