[PATCH] ath10k: Replace bit shifts with the BIT() macro for rx desc bits

Marcus Folkesson marcus.folkesson at gmail.com
Wed May 9 00:40:42 PDT 2018

Hello Govind,

On Wed, May 09, 2018 at 10:18:04AM +0530, Govind Singh wrote:
> Use the BIT() macro from 'linux/bitops.h' to define the rx desc
> bit flags to have consistency with new definitions.
> Signed-off-by: Govind Singh <govinds at codeaurora.org>
> ---
>  drivers/net/wireless/ath/ath10k/rx_desc.h | 134 +++++++++++-----------
>  1 file changed, 67 insertions(+), 67 deletions(-)
> diff --git a/drivers/net/wireless/ath/ath10k/rx_desc.h b/drivers/net/wireless/ath/ath10k/rx_desc.h
> index 545deb6d7af1..b3d7c6e7ac90 100644
> --- a/drivers/net/wireless/ath/ath10k/rx_desc.h
> +++ b/drivers/net/wireless/ath/ath10k/rx_desc.h

Looks good, but please include linux/bitops.h as well.

From the documentation [1]:

If you use a facility then #include the file that defines/declares
 that facility.  Don't depend on other header files pulling in ones
 that you use.

[1] Documentation/process/submit-checklist.rst

Best regards
Marcus Folkesson
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/ath10k/attachments/20180509/63b6adaa/attachment.sig>

More information about the ath10k mailing list